Bigblade SDH GraphIt Workloads #723
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrutt92
force-pushed
the
bigblade-sdh-workloads
branch
from
4d2d896
to
59eae8d
Compare
mrutt92
force-pushed
the
bigblade-sdh-workloads
branch
from
59eae8d
to
bcfc393
Compare
drichmond
reviewed
May 3, 2021
Comment on lines
+247
to
248
| kernel.riscv: crt.rvo bsg_set_tile_x_y.rvo bsg_tile_config_vars.rvo main.rvo $(RISCV_TARGET_OBJECTS) $(RISCV_LINK_SCRIPT) | ||
| $(RISCV_LD) -T $(RISCV_LINK_SCRIPT) $(RISCV_LDFLAGS) $(filter %.rvo,$^) -o $@ |
There was a problem hiding this comment.
Yeah, I changed this when adding support for multiple kernels. Open to other solutions though.
drichmond
reviewed
May 3, 2021
examples/graphit/riscv.mk
Outdated
Comment on lines
1
to
3
| # Copyright (c) 2019, University of Washington All rights reserved. | ||
| # | ||
| # Redistribution and use in source and binary forms, with or without modification, |
There was a problem hiding this comment.
Do we need this now that we have one in cuda?
There was a problem hiding this comment.
No, this file can be deleted (and is on my list to remove when removing the dummy vec add test from the graphit directory as well).
…ing to refactor test
…e with prefetching kernel
drichmond
reviewed
May 10, 2021
Comment on lines
+1
to
+4
| /* | ||
| * This kernel prints the Hello World message | ||
| */ | ||
|
|
There was a problem hiding this comment.
Hey, sometimes comments lie.
drichmond
reviewed
May 10, 2021
Comment on lines
+4
to
+5
|
|
||
| // BSG_TILE_GROUP_X_DIM and BSG_TILE_GROUP_Y_DIM must be defined |
There was a problem hiding this comment.
Are all the versions for {Beam Search, Greedy Walk, Dot Product, Inner Product} used?
drichmond
reviewed
May 10, 2021
|
@eafurst Yes, the apps should verify correctness |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.